Skip to content

fix(delete-user-data): gate RTDB deletion on a configured instance #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CorieW wants to merge 2 commits into
base: kits
Choose a base branch
from
Open

fix(delete-user-data): gate RTDB deletion on a configured instance #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b475b70
fix(delete-user-data): gate RTDB deletion on a configured instance
CorieW Aug 26, 2026
741dcc6
chore(delete-user-data): drop redundant parity comments
CorieW Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kits/delete-user-data/src/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import type { DocumentReference } from "firebase-admin/firestore";
import { FieldPath } from "firebase-admin/firestore";
import chunk from "lodash.chunk";
import * as events from "./events";
import { getDatabaseUrl } from "./export-config";
import { extractUserPaths, hasValidUserPath } from "./helpers";
import * as logs from "./logs";
import { recursiveDelete } from "./recursiveDelete";
Expand Down Expand Up @@ -156,7 +157,10 @@ export async function handleClear(
} else {
logs.firestoreNotConfigured();
}
if (ctx.config.rtdbPaths) {
if (
ctx.config.rtdbPaths &&
getDatabaseUrl(ctx.config.rtdbInstance, ctx.config.rtdbLocation)
) {
promises.push(clearDatabaseData(ctx.config.rtdbPaths, uid, ctx));
} else {
logs.rtdbNotConfigured();
Expand Down
23 changes: 21 additions & 2 deletions kits/delete-user-data/tests/handlers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,11 @@ describe("handleClear", () => {

test("deletes the configured rtdb paths", async () => {
const ctx = makeContext({
config: { rtdbPaths: "users/{UID},admins/{UID}" },
config: {
rtdbPaths: "users/{UID},admins/{UID}",
rtdbInstance: "test-rtdb-instance",
rtdbLocation: "us-central1",
},
});

await handleClear(UID, ctx);
Expand All @@ -418,6 +422,17 @@ describe("handleClear", () => {
});
});

test("skips rtdb deletion when no database instance is configured", async () => {
const ctx = makeContext({
config: { rtdbPaths: "users/{UID}" },
});

await handleClear(UID, ctx);

expect(ctx.rtdbRemovals).toEqual([]);
expect(log.rtdbNotConfigured).toHaveBeenCalled();
});

test("deletes the configured storage paths", async () => {
const ctx = makeContext({
config: {
Expand Down Expand Up @@ -463,7 +478,11 @@ describe("handleClear", () => {
test("logs rtdb errors without failing", async () => {
const error = new Error("boom");
const ctx = makeContext({
config: { rtdbPaths: "users/{UID}" },
config: {
rtdbPaths: "users/{UID}",
rtdbInstance: "test-rtdb-instance",
rtdbLocation: "us-central1",
},
rtdbError: error,
});

Expand Down
Loading