Skip to content

fix(firestore-vector-search): bind provider secrets to task functions #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CorieW wants to merge 2 commits into
base: kits
Choose a base branch
from
+6 −4
Open

fix(firestore-vector-search): bind provider secrets to task functions #2987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a505ed
fix(firestore-vector-search): bind provider secrets to task functions
CorieW Aug 26, 2026
1ea77fa
chore(firestore-vector-search): correct the secret-binding rationale …
CorieW Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions kits/firestore-vector-search/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,19 @@ const REQUIRED_APIS = [
},
] as const;
const FUNCTION_SECRETS = [geminiApiKey, openAiApiKey];
// Only the task functions reach getSingleEmbedding, but every function here
// resolves the same config (which reads the provider keys), and the extension
// bound its secrets to all functions in the instance -- so bind them uniformly.
const DEFAULT_TASK_OPTIONS = {
memory: "512MiB",
timeoutSeconds: FUNCTION_TIMEOUT_SECONDS,
secrets: FUNCTION_SECRETS,
} as const;
const EMBEDDING_TASK_OPTIONS = {
memory: "1GiB",
timeoutSeconds: FUNCTION_TIMEOUT_SECONDS,
retryConfig: { maxAttempts: TASK_MAX_ATTEMPTS },
secrets: FUNCTION_SECRETS,
} as const;
const FIRESTORE_FUNCTION_OPTIONS = {
memory: "512MiB",
Expand Down Expand Up @@ -191,10 +196,7 @@ export const queryCallable = onCall(CALLABLE_FUNCTION_OPTIONS, (request) =>
);

export const initVectorSearch = onTaskDispatched(
{
...DEFAULT_TASK_OPTIONS,
secrets: FUNCTION_SECRETS,
},
DEFAULT_TASK_OPTIONS,
async () => {
await handleInit(getContext());
}
Expand Down
Loading