Repository navigation
Qualify Workbench job transitions in shared MCK - #1046
Merged
Merged
Conversation
Keep large numeric arrays inline so transition cases remain reviewable. Preserve every input and independent expected value.
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged job receipt profile needs independent transition evidence. Add 170 parent-owned fixed traces to the existing shared Workbench MCK, covering cancellation races, immutable authority/snapshot/call binding, replay/conflicts, rejected-action retention and same-session reconnect. A host acknowledgement can still be followed by a returned value and separate cleanup failure.
Exact offline MCK draft.6 advertises only
reduce-joband JSON, mapping the unchanged jobs draft.1 and terminal draft.5 profiles. The runner admits bounded canonical observations, compares fixed expectations and independently recomputes saved report verdicts. It never sends expectations or case IDs to adapters, decodes inputs to derive goldens, or implements another reducer. Historical schema/corpus paths remain byte-identical. This adds no live host RPC or connected capability.Validation:
The fixed corpus SHA-256 is
1a76960435015be235211ee68adaff66a4997e991f96456a493d5cd75ebb61f8. Large boundary arrays are kept inline without changing any input or independent expected value.Tracked by shared bead
morphir-etg2.11; local HTML plans contain Mermaid/SVG and done/pending checkboxes. Live authenticated host/UI job integration remains the following slice.