Repository navigation
feat(workbench): collect bounded originals observations - #200
Merged
Merged
Conversation
Expose passive bounded observations for actual model adoption, archive operations, download outcomes and closure. Share one module across the standard and observed entries, and keep observer failures separate from application effects.
Keep the shared worker graph free of DOM-only names while retaining browser Document identity. Signed-off-by: Damian Reeves <[email protected]>
Retain adjacent synchronous observer facts without waiting for a future transport ACK. Keep fixed backing, sticky faults and terminal ordering separate from document transport and host authority. Signed-off-by: Damian Reeves <[email protected]>
Retain actual callbacks before one-at-a-time acknowledged delivery. Stop the same observer before END and refuse incomplete or unclean channel termination. Signed-off-by: Damian Reeves <[email protected]>
Signed-off-by: Damian Reeves <[email protected]>
DamianReeves
marked this pull request as ready for review
October 22, 2026 06:51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Damian Reeves <[email protected]>
Resolve the Bun 1.4.4 update against the workbench workspace and its added dependencies. Signed-off-by: Damian Reeves <[email protected]>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2026
DamianReeves
added a commit
that referenced
this pull request
Oct 23, 2026
The squash commit of #200 has the same tree as merging 39df05e with 6a0c4fb. Both commits are already ancestors of this branch, so this merge records the squash commit without changing the tree. Signed-off-by: Damian Reeves <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controlled Workbench needs lifecycle evidence from its real originals workflow. Add a separate observed page that attaches recording before application startup, a bounded UTF-8 event journal, and a same-origin document channel with retained events before ACK. Ordinary application startup continues without an observation sink.
This carries the frontend observation slice forward from merged #198. Canonical engine allocation, native host/document/action/Download ownership, shared factual checking and saved replay remain tracked in morphir-etg2.22.1.2 and morphir-etg2.22.2. The parent browser mode remains disabled pending that integration and full qualification.
Validation on c20571a:
Current head 1ec2c41 merges main4af58d0d, including the repository-task migration, diagramming skill and documentation updates. The actual merge tree5c155ccd matches the separately computed conflict-free expected tree. Application sources, package locks and headless host/release scripts are byte-identical to c205; generated IR test changes only identify the new fixture generator in comments. Lint, formatting, validation and actual clean-environment pre-push hooks pass using main's new MoonBit task scripts. Existing CI is running on this exact head. Both preceding PR200/201 workflows completed before this push, without cancellation. No new CI jobs, matrices or triggers were added. The earlier local build/image is not relabeled as a new current-head build.
Local Chrome for Testing reruns remain pending during the keychain-prompt investigation. Earlier source-specific browser evidence is historical. Full profile, platform and campaign qualification remain open. PR201 stays stacked on this branch and will consume the refreshed parent after this candidate's checks finish.