Repository navigation
Harden release notes and validate updates and helper messages - #117
Merged
fif7y merged 1 commit intoOct 30, 2026
Merged
Conversation
Narrow the security changes to the subset requested on PR 114, based on roster. Keep CFMessagePort, Sparkle dependency configuration, and nonfatal DMG spctl assessment unchanged. Add payload validation and update-signature verification with focused regression tests. Co-authored-by: Copilot <[email protected]> Copilot-Session: 165b0dbb-9a37-49a5-b437-05c62fcaa0a2
akshaymaloo
marked this pull request as ready for review
October 30, 2026 01:01
Owner
|
Hey @akshaymaloo, this is exactly the scope I was hoping for, thanks! I ran the new update check against the real 0.3.4-beta.1 DMG and it passes, and a copy with one byte changed fails. Your tests pass too, and the release notes popover keeps its height with the new policy. Merging it now, it should be in the next beta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Smaller replacement for #114, targeting
rosteras requested in #114 (comment).Kept
Left unchanged
CFMessagePorttransport. No sockets, temporary-directory endpoints, signature checks on helper peers, executable-path checks, or debugger restrictions.project.ymland Sparkle dependency selection. No Sparkle bump or new pin.spctl ... || truebehavior for the stapled, non-code-signed DMG.The message checks validate payloads; they deliberately do not introduce peer authentication.
Validation
On macOS 27.2 / Xcode 27.1:
HelperProtocolTestspassed, including valid messages, the exact message-size boundary, oversized valid JSON, item counts, duplicate titles, UTF-8 byte lengths, image data, geometry, and event validation.ac2def288cbff5cfc7df3ffef6abdf45b72bcb0a). The version was selected only in the ignored, generated local lockfile for this compatibility check; the PR does not change dependency configuration.spctlreturning exit 3 without blocking verification, invalid signatures remaining fatal, missing tooling, and cryptographic acceptance/rejection of generated and tampered fixtures.bash -n scripts/release.shandgit diff --checkpassed.A production notarized release was not run. Release orchestration is covered by offline test doubles; update-signature verification is exercised with real Ed25519 fixtures.