Repository navigation
Fix cancellation-related animation stalls - #113
akshaymaloo wants to merge 1 commit into
Conversation
Stop cancelled quiet-wait polls and prevent superseded captures from clearing newer capture state or publishing stale snapshots. Add cancellation regression tests. Co-authored-by: Copilot <[email protected]> Copilot-Session: 165b0dbb-9a37-49a5-b437-05c62fcaa0a2
|
Thanks for the pull request! Dimble asks contributors to sign a short Contributor License Agreement (you keep your copyright, see CLA.md). Please post the sentence below as a comment to sign it. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have read the CLA Document and I hereby sign the CLA |
…celled one stops waiting out a lift Follow-up to Akshay's fix. The flag was cleared by any capture that wasn't cancelled, so a cancel without a replacement would leave it on and every reveal would wait out coverRetakeWait. A generation token ties it to the latest capture instead. The lift wait was a second spin: a cancelled sleep returns at once, so a replaced capture looped for up to liftCoverSafety. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Hey @akshaymaloo, really good PR, thanks! Both bugs are real, and the flag one was the nasty one, a reveal could run without its cover picture. I ported it onto It should be in the next beta. |
Summary
Animation-only replacement for the relevant part of #112. This branch is based directly on
mainand has no dependency on the security changes.Validation
TransitionCancellationTestsandBarSnapshotCropTests.git diff --checkpassed.Remaining validation
This is a draft. Live rapid hover/click cycles and multi-display animation still need verification on an installed, signed build. The current cancellation tests do not directly simulate every overlapping capture-completion ordering.