feat: implement shell section - #227
Merged
Merged
Conversation
mortenengen
added
enhancement
6 of 18 tasks
* Add shell reinforcement * Add shell geometry
* Added validation for z-value and scaled the visualization * Removed 'return self' and 'return None' --------- Co-authored-by: Morten Engen <[email protected]>
* Add get_stress_2d and get_tangent_2d methods * Add separate elastic class for 2D operations * Add tests for Elastic2D methods get_stress and get_tangent. * Establish the C_matrix as an internal attribute and a property + various fixes * Change 'math.isclose...' to 'np.allclose...' * Verified ValueError and removed misplaced comment in get_stress method --------- Co-authored-by: Morten Engen <[email protected]>
* Add shell fiber integrator * Removed strain at fiber as argument for Elastic2D get_tangent method * Improve triangulation logic and various fixes to prepare_input per review comments * Use zip() in integrate_modulus and only generate default mesh_size when z_coords is None --------- Co-authored-by: Morten Engen <[email protected]>
…#241) * Replace tangent stiffness with secant stiffness for 2D materials * Replace 'tangent' with 'secant' in tests
* Fix add_reinforcement to validate single ShellReinforcement object correctly * Add tests for ShellGeometry and ShellReinforcement, and add ._shell_geometry.py to __init__.py * Remove duplicate line
* Add stiffness matrix for reinforcement * Changed names for global and local material matrix * Reinforcement integration in prepare_input and drop redundant geometry argument * Move transformation matrix from integrator to ShellReinforcement * Updated prepare_input for reinforcement
* Add side view to repr_svg in ShellGeometry * Revert "Updated comment" This reverts commit 4ca1ad0, reversing changes made to 9823d2a. * Updated files with errors * Fixed difference in not relevant file * Ignore too many statements in repr_svg --------- Co-authored-by: Morten Engen <[email protected]>
* Add ParabolaRectangle2D material class * Add ParabolaRectangle2D material in __init__ * Split class into modular methods for transform, correction, and cracking * Add more tests to ParabolaRectangle2D class * Add coefficient for compressive-strength reduction due to lateral shear * Update tests accounting for compressive-strength reduction * Update docstrings * Fix computations related to principal strain direction and correct length of strain vectors as per review comments * Avoid division by zero in get_secant method * Update test results after corrections in commit 35898f8
* Add shell section * Import shell classes to __init__ files * Make section_calculator a public attr of ShellSection * Make sure the layer information is stored * Make sure strain is an array * Draft iterative solver * Update tests to reflect how mesh_size is propagated * Make sure the stiffness matrix is returned correctly * Separate treatment of current and initial stiffness * Check number of iterations at the beginning of an iteration --------- Co-authored-by: Morten Engen <[email protected]>
* Make the secant stiffness matrix consistent * Refine computation of secant stiffness * Add more tests for get_secant method * Update Poisson matrix as per review comments
* Fix misleading variable name in integrate_stress method * Changed variable name to fiber_stress
* Add shell section * Import shell classes to __init__ files * Make section_calculator a public attr of ShellSection * Make sure the layer information is stored * Make sure strain is an array * Draft iterative solver * Update tests to reflect how mesh_size is propagated * Make sure the stiffness matrix is returned correctly * Separate treatment of current and initial stiffness * Check number of iterations at the beginning of an iteration * Add tests for shell section --------- Co-authored-by: Morten Engen <[email protected]>
mortenengen
force-pushed
the
implement-shell-section
branch
from
August 28, 2025 19:50
e9e09d3 to
c1fceef
Compare
* Update target values in new tests * Merge dev * Accept only materials in shell geometry and reinforcement * Update tests
* Add stress and modulus transformation as props of shell reinf * Avoid matrix multiplication during iterations
* Change to an energy based convergence criterion for the shell section * Update tests
…wisting curvature (#339)
…ering convention (#345)
… size (#353) * Specify the number of integration layers instead of a relative size of each layer * Update tests
…om generalized shell strains (#354)
mortenengen
marked this pull request as ready for review
September 14, 2026 12:05
talledodiego
left a comment
talledodiego
left a comment
Collaborator
There was a problem hiding this comment.
Thanks so much for this outstanding contribution. Just some minor comments/questions. Eventually for future PR (shall we in case document some future work in proper issues?)
5 tasks
6 of 18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tracks the development related to #225.