Repository navigation
chore: delete unused features (friend challenge, giveaway, chat economy, stars, extra popups) and dead helpers - #390
Merged
Conversation
…my, stars, extra popups) and dead helpers Removes features with zero or near-zero prod usage and helpers with no callers outside tests. DB tables are kept (no drop migration); TrxType enum members are kept for historical treasury_trx rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes features the owner decided to kill based on prod usage, plus helpers with no callers outside tests. 47 files, +41 / −3810.
/friend+ callback registration,fc_branch in/start, offer after like,FRIEND_CHALLENGE_ENABLED, localization, tests,docs/analyst/friend-challenge-h12.sql, implementation doc. H12 marked KILLED indocs/growth/HYPOTHESES.mdtreasury/giveaway.py, bothgiveaway_branches in/start,test_giveaway.pygiveawaytransactions ever+Ntransfers and+fire Nactivity rewards (chat/send_tokens.py,transfer_tokens,get_active_chat_users)active_in_chat2025-01-22payments/purchase.py, buy buttons on/balance, pre-checkout/successful-payment//refundhandlers,mint_tokens)purchase_tokenrows ever, last 2025-11-21admin/boost.py,ChatBoostHandler)upload_meme,telegram_channel,github_repo,feedback(+popups.yml, channel-subscribe check and events)admin/waitlist.py(never registered),get_waitlist_users_registered_before,waitlist.ymlstats/service.py,RedisData/set_redis_key/get_by_key,charge_user,get_latest_chat_messages,UserTg,check_openrouter_key_health,get_source_candidate_vote_counts,TREASURY_USER_IDget_usable_openrouter_keys/ a direct vote select)n_sub_likesshadow enrichmentTabledefs with 0 references:meme_raw_ig(+2 SQL joins),user_channel_membership,channel_lifecycle_event,editorial_posts/_snapshots(+ editorial branch instats_collector.py, crosspost path untouched),inline_search_*,user_wrapped,chat_agent_usage,friend_challenge_*openai(0 imports),pydantic[email]→pydantic(noEmailStr),OPENAI_API_KEYKept on purpose:
alembic revision --autogeneratewill now propose dropping the tables whoseTabledefs were removed, so strip those ops from future autogenerated migrations.TrxTypemembers andPAYOUTSentries, for historicaltreasury_trxrows.friend_challengeexclusion in meme stats SQL. It does nothing now but is harmless.specs/burger-tokenomics.mdupdated to match.Tests (local):
tests/tgbot tests/crossposting tests/stats tests/storage tests/test_crossposting_meme.py315 passed;tests/flows tests/test_redaction_audit.py35 passed.tests/adminfails to collect locally because of an unrelated FastAPI version mismatch in my local env.ruff checkandruff formatare clean.