Repository navigation
chore(reco): delete closed ranking experiments and dormant flags - #389
Merged
Merged
Conversation
Remove recently_liked_blender_v2 / text_light_blender_v1 / viral_shares blender code, cold_start_fresh_viral_v1, source-diversity + shadow-score + full-payload/Sentry-span diagnostics, the always-off disliked-source block filter and the disabled channel-viral broadcast pick. explore_budget_v1, the text_light_lr_smoothed engine, the demote policy and the compact 'recommendation batch diagnostics' log line stay. Feed output unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletion-only cleanup of closed ranking experiments and flags that are off in production. The feed every user gets does not change.
What was deleted
recently_liked_blender_v2(assignment, Redis 7d-LR quartile cache and lock, weights hook) inblender_experiments.pyMATURE_BLEND_WEIGHTSfor every user, which is whatplan.blend_weightsholds for mature users. The quartile cache had no other caller.text_light_blender_v1weights overlay and_fixed_pos_for_weightsmeme_queuepassedtext_light_blender_v1_enabled=False. The fixed-position remap only fired whentext_light_lr_smoothedwas in the weights, which never happens on the growing or mature plans.viral_sharesengine plus the close-out stubget_mature_blend_weights_with_experimentsviral_shares_blender_v1was killed on 2026-10-30.cold_start_experiments.pyand the fresh-viral branches inmeme_queue/pipeline/candidates(max_age_days, thecold_start_explore_fresh*labels)COLD_START_FRESH_VIRAL_EXPERIMENT_ENABLEDdefaults to false and is explicitly set tofalsein the prod env. The experiment was killed on 2026-10-30.diversify_candidates_by_source), shadow score summary, full-payload sampler, Sentry span helpers, and their flags (RECOMMENDATION_SOURCE_DIVERSITY_ENABLED,RECOMMENDATION_SHADOW_SCORING_ENABLED,RECOMMENDATION_DIAGNOSTICS_SAMPLE_RATE)RECOMMENDATION_BLOCK_DISLIKED_*andblock_disliked_sources_sql_filter(11 call sites)"".BROADCAST_CHANNEL_VIRAL_PICK_ENABLEDtest_cold_start_fresh.py,test_block_disliked_sources.py, the v2/text-light cases intest_blender_experiments.py,test_meme_queue.pyandtest_pipeline.py, and the channel-viral cases intest_broadcast_pick.pyWhat stays
explore_budget_v1and everything it uses: assignment,fresh_viralengine and filter, bad-fresh drop, idle-return slot, labeling-budget low_sent query.text_light_lr_smoothedengine, which is the cold-start CS3 weight and fallback.recommendation batch diagnosticslog line. It still has the fields named in the explore-budget guardrail (selected_count,last_resort_used). It no longer has the keys for the removed features (source_diversity_*,shadow_*,cold_start_fresh_applied, thefull_jsonpayload).Verification
tests/recommendations,tests/feed_turnandtests/broadcasts, plus the sentry, experiment-assignment, redis, tgbot next/start/friend-challenge and crossposting tests: all pass locally (194 + 42 passed, 2 skipped).ruff checkandruff formatare clean.Diff stat
The
COLD_START_FRESH_VIRAL_EXPERIMENT_ENABLED=falseentry in the prod env can be removed after merge. It is harmless if left.