feat(init): enable ALLOW_UNCREDENTIALED_DELIVERY_SECRETS in the scaffolded auth env#77
Merged
Merged
Conversation
…olded auth env Companion to the email_otp default: with it set, seamless login --local reads the OTP from the auth server's response instead of needing a mail provider, so signing in to a fresh local stack works end to end. Dev-only — the auth server ignores it under a production NODE_ENV, and the scaffold runs as development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to the
email_otpscaffold default (#75).buildAuthEnvnow setsALLOW_UNCREDENTIALED_DELIVERY_SECRETS=trueon the generated auth server env, soseamless login --localreads the OTP straight from the auth server's response instead of needing a mail provider. Combined withemail_otpin the default login methods, signing in to a freshly scaffolded local stack now works end to end with no manual config.Safety
Dev-only escape hatch. The auth server ignores it under a production
NODE_ENV(externalDelivery.ts→uncredentialedSecretsAllowed()returns false and logs an error whenNODE_ENV=production), and the scaffold runs asdevelopment. Deployers overridingNODE_ENV=productionget the safe behavior automatically.Testing
tsc,eslint,buildclean; 588 tests pass.docker.test.tsasserts the flag is set inbuildAuthEnv's docker-mode output.Branches off
main(post-#75); independent of the console-hosting PR (#74).