fix(verify): bump released-smoke adapter to @seamless-auth/express ^0.9.0#118
Merged
Conversation
….9.0 The released conformance smoke (local:false) builds the harness adapter against the published @seamless-auth/express. Pinned at ^0.8.0 it resolved 0.8.0, which still served the OTP/magic-link generate routes as GET. The harness adapter flows and @seamless-auth/react 0.5.0 both POST those routes, so every adapter (and downstream react) flow failed with generate-email-otp -> 404. express 0.9.0 serves them as POST, matching both consumers. This is the version the source (local:true) conformance already builds from, so the pin bump simply brings released-smoke in line with the CLI conformance workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the conformance harness adapter's
@seamless-auth/expresspin from^0.8.0to^0.9.0inverify/adapter-app/package.json.Why
released-smoke(the dailylocal:falserun) has been red since July 11. The failure was not a Node version issue — the "Node 20 deprecated" lines in the logs are the standard GitHub Actions runner notice.Two things were going on:
The auth-api startup crash seen in the last run (
docker failed, container exited on boot) was the missing-FRONTEND_URLcrash — already fixed inmain(the FRONTEND_URL / rate-limit / POST-routes commits all merged ~7h after the last observed failing run).The remaining failure is this one: the pin resolved published
@seamless-auth/[email protected], which still serves the OTP/magic-linkgenerate-*routes as GET. The harness adapter flows and@seamless-auth/react0.5.0 both POST those routes → every adapter (and downstream react) flow failed withgenerate-email-otp -> 404.0.9.0serves them as POST.The
^0.8.0pin only affectslocal:false(released) runs — inlocal:trueconformance the source 0.9.0 tarball is installed over it. So this bump simply brings released-smoke in line with what the CLI conformance workflow already builds.Verification
Reproduced the full matrix locally. Before:
✖ API / adapter(4×generate-email-otp -> 404). After:✔ API / adapteron express 0.9.0, across two runs (source and released).The browser (react) layer can't be exercised reliably on the arm64 dev machine — it fails identically even with the source SDKs that pass in CI — so final green confirmation should come from a
released-smokeworkflow_dispatchrun.