Repository navigation
Show episode notes in full instead of behind Show more - #120
Merged
Merged
Conversation
The episode page capped show notes at 8 lines with a Show more / Show less toggle. Because the notes TextView uses LinkMovementMethod (a scrolling movement method), the capped view also scrolled internally, leaving a line cut off at the top. Drop the cap and the toggle so the notes render at full height and the page's own scroll reveals them. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01RK5hqcE13d42xpsT576dRw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The episode page capped show notes at 8 lines, with a Show more / Show less toggle. The notes
TextViewusesLinkMovementMethod, which is a scrolling movement method, so the capped view also scrolled inside itself. That left a line cut off at the top of the box.This PR removes the
maxLinescap, the ellipsis, theanimateContentSizeand the toggle (EpisodeDetailScreen.kt). The notes now render at full height, and the page's existingverticalScrollreveals them. Links in the notes stay tappable.The version goes from 1.6.76 (124) to 1.6.77 (125), with a What's New entry.
Testing
Local compilation could not be run: Gradle can't resolve dependencies in the agent environment. The CI
buildcheck (all unit tests plusassembleDebug) is the compile check for this PR. No tests referenced the toggle.Generated by Claude Code