Repository navigation
Conversation
# Conflicts: # bin/mosquctl_site # bin/start_butler # bin/start_mosquitto # bin/start_udmis # etc/tmux_common.sh
|
|
||
| # Externals | ||
| externals = metadata.setdefault("externals", {}) | ||
| dbo = externals.setdefault("dbo", {}) |
There was a problem hiding this comment.
Since we're migrating guid to system.guid and no longer writing externals.dbo.ext_id, should we also add dbo.pop("ext_id", None) here so existing site models that already have ext_id under externals.dbo get cleaned up when dbo_merge runs?
Comment added by Gemini
| target_guid = device_id_to_guid.get(target_id, target_id) | ||
| if isinstance(relation, dict) and relation: | ||
| # Match string enum format expected by schema | ||
| rel_type = list(relation.keys())[0] |
There was a problem hiding this comment.
In bin/dbo_merge, dbo.connections[target_name] is stored as a list of relationship types so a device can have multiple connection types to the same target. Here in dbo_extract, list(relation.keys())[0] only extracts the first relationship type and drops any others—should we iterate over the list of relationship types (when isinstance(relation, list)) so round-tripping through dbo_extract preserves all connections?
Comment added by Gemini
No description provided.