Skip to content

Fix keygen twice generating private key for RS256_X509 auth type - #1457

Merged
grafnu merged 1 commit into
faucetsdn:masterfrom
duncangreene:bugfix/keygen-rs256_x509-private-key-regeneration
Oct 21, 2026
Merged

grafnu merged 1 commit into
faucetsdn:masterfrom
duncangreene:bugfix/keygen-rs256_x509-private-key-regeneration

Conversation

@duncangreene

Copy link
Copy Markdown
Contributor

Closes #1456.

@noursaidi
noursaidi requested a review from grafnu October 21, 2026 17:50

@grafnu grafnu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized there's some test failures that should be resolve or sorted before submitting...

@grafnu
grafnu merged commit b7db83d into faucetsdn:master Oct 21, 2026
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bin/keygen unnecessarily generating new private key leaving behind invalid rsa_public.pem in RS256_X509 mode

2 participants