Repository navigation
fix: preserve header tokens with whitespace preceding commas in vary parser - #423
Open
TalhaHunter101 wants to merge 1 commit into
Open
TalhaHunter101 wants to merge 1 commit into
TalhaHunter101 wants to merge 1 commit into
Conversation
…parser Signed-off-by: Talha Shafeeq <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
Description
In
vary.js,parse(header)advancespos = i + 1when encountering whitespace. If whitespace occurs immediately before a comma (e.g.Origin , Accept-Encoding),posbecomes equal to the index of the comma, sopos !== ievaluates to false, causing the token before the comma to be dropped completely.This PR:
parse()to locate tokens between delimiters and trim leading/trailing whitespace (spaces and tabs per RFC 9110 OWS rules) without dropping tokens.charCodeAt.