Repository navigation
test: transpile ESM-only cookie@2 in jest suite - #536
Merged
Merged
Conversation
Tony133
marked this pull request as ready for review
October 27, 2026 22:06
ilteoood
requested changes
Oct 28, 2026
Member
Author
Done, moved to |
ilteoood
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
[email protected]bumpedcookieto 2.x, which is ESM-only. Thetypescript-jestsuite runs in CommonJS through ts-jest, so Jest can no longerrequire()cookie/dist/index.jsand everyapp.inject()call fails:https://github.com/fastify/fastify-autoload/actions/runs/40437079305/job/122488466342?pr=535#step:5:88
The failure only shows up on a fresh install (no lockfile in the repo), which is why it appeared on CI before local environments with an older
node_modules.Changes:
transformIgnorePatternssocookieis no longer skipped by the transform.jswithallowJs: truesocookieis compiled to CJSThe exception is scoped to
cookie/only; the rest ofnode_modulesis still ignored. Works on every Node version in the CI matrix, independent of Jest's nativerequire(esm)support.