fix(logging): resolve basedpyright errors in log channels - #225
Merged
Merged
Conversation
Declare the `driver`/`max_level` attributes on BaseChannel via a LogDriver protocol and `channels` on MultiBaseChannel, and resolve driver/channel classes through explicit None-checks instead of calling an Optional. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…hannels Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all basedpyright errors in
fastapi_startkit/logging/channels/(8 files).BaseChannel: declaresdriver: LogDriver(new structuralProtocol) andmax_level: str | None; addsdriver_class()which resolves viaDriverFactory.makeand raisesValueErrorfor an unknown driver instead of callingNone.BaseChannel.channel(): same None-guard aroundChannelFactory.make.MultiBaseChannel/StackChannel: declarechannels: list[BaseChannel]; stack channel default usesConfig.get(...) or [](matches thestr | Nonedefault in theConfigfacade stub).DriverFactoryimports in the concrete channels.Rules fixed:
reportAttributeAccessIssue(34),reportOptionalCall(6),reportArgumentType(1).DriverFactory.make/ChannelFactory.makeare unchanged (they still returnNonefor unknown names). The only runtime difference: an unknown driver/channel name now raises a clearValueErrorwhere it used to raiseTypeError: 'NoneType' object is not callable.Verification
uv run basedpyright: 628 → 587 errors (−41), warnings unchanged (113), no new errorsuv run pytest --ignore=tests/masoniteorm/postgres: 2355 passed, 7 skipped🤖 Generated with Claude Code