feat: add optional jiff 0.2 shape support - #19
Merged
Conversation
Why: configuration consumers use Jiff types whose Serde implementations accept and emit strings, but orphan rules prevent downstream crates from adding serde-shape's traits themselves. Provide a no_std-compatible jiff02 feature for every Jiff 0.2 type with direct Serde implementations, and exercise it in the repository workflows.
Why: an optional integration is only discoverable when users can see which dependency version and concrete types it covers. Document the jiff02 feature and its string-shape contract without implying support for Jiff's alternate Serde adapters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jiff02feature backed by Jiff 0.2 without enabling its default featuresThe implementation deliberately does not describe Jiff's alternate
serdeadapters: those remain custom-function boundaries unless a consumer supplies an explicitserde_shapehook.Review order
c4c99b7 feat: add optional Jiff 0.2 shape support29e0b4d docs: describe the Jiff integrationValidation
cargo x lintcargo x build --lockedcargo x testcargo x package --lockedcargo +1.85.0 x testcargo +1.85.0 check -p serde-shape --lib --no-default-features --features jiff02 --target thumbv7em-none-eabihf