Repository navigation
Place the analyzer ad manually and floor the progress card height - #384
Merged
Merged
Conversation
A real AdSense unit in the auto-format slot can be far taller than the 90px the live view assumed (250-280px was enough), which squeezed the progress card until its grid and steps were cut off. DisplayAdSafe gets a `fixed` mode used by the analyzer: no data-ad-format, the box is 320x100, 468x60 or 728x90 by width and reserved from first paint, so whatever fills it cannot resize the page. The live wrapper is now min-height (not height) with a 24rem floor for the card, so any remaining extra height scrolls instead of crushing the card. Checked in Chrome and Firefox at six sizes, including a forced 600px-tall creative inside the slot. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DisplayAdSafegets afixedmode (used by the analyzer): nodata-ad-format, box is 320x100 / 468x60 / 728x90 by width, reserved from first paint.min-heightwith a 24rem floor for the card, so extra height scrolls instead of crushing the card.Test plan
npm run check(850 tests, typecheck, build, hydration)🤖 Generated with Claude Code