V2.5based dev - #1
Closed
fanshiqing wants to merge 39 commits into
Closed
Conversation
…VIDIA#1856) Use public API instead of removed private function * replaced use of _load_state_dict_into_model with model.load_state_dict because the private function _load_state_dict_into_model was removed in huggingface/transformers#36335 Signed-off-by: Jan Bielak <[email protected]>
* Manage deps and add einops Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Update build.yml Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
* Support MLA (qk_dim != v_dim) for AttnFuncWithCPAndKVP2P Signed-off-by: Yuzhong Wang <[email protected]> * add UT for MLA CP Signed-off-by: Yuzhong Wang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * refine the code Signed-off-by: Yuzhong Wang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * refine the code Signed-off-by: Yuzhong Wang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Yuzhong Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xin Yao <[email protected]> Co-authored-by: Xiaowei Ren <[email protected]>
* Initial basic setup Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * rm setup reqs Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * fix Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * buil-isolation support Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * rm not needed funcs Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fix workflows Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * fix wheel Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fix invalid wheel Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fix JAX build in baremetal env Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Update install inst in readme Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Update build.yml Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * docstring fix Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * fix Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
) Fix for loading old ckpt formats Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
typo fix Signed-off-by: Pawel Gadzinski <[email protected]>
* Implemented GroupedDense and TestGroupedDense for BF16, FP16, and FP8 * Fix GroupedGemmFFI cuBLAS workspace alignment bug Signed-off-by: Hua Huang <[email protected]> Signed-off-by: Phuong Nguyen <[email protected]>
* Added double buffering support initial commit Signed-off-by: Selvaraj Anandaraj <[email protected]> * Fixed bugs Signed-off-by: Selvaraj Anandaraj <[email protected]> * Make only one double buffer creation Signed-off-by: Selvaraj Anandaraj <[email protected]> * Fixed bug Signed-off-by: Selvaraj Anandaraj <[email protected]> * Fixed typo Signed-off-by: Selvaraj Anandaraj <[email protected]> * Fixed flag setting Signed-off-by: Selvaraj Anandaraj <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Merge conflict Signed-off-by: Selvaraj Anandaraj <[email protected]> * fixes Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * lint fix Signed-off-by: Pawel Gadzinski <[email protected]> --------- Signed-off-by: Selvaraj Anandaraj <[email protected]> Signed-off-by: Selvaraj Anandaraj <[email protected]> Signed-off-by: Selvaraj Anandaraj <[email protected]> Signed-off-by: Pawel Gadzinski <[email protected]> Co-authored-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Paweł Gadziński <[email protected]> Co-authored-by: Pawel Gadzinski <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Revert "[JAX] GroupedDense v.2 without dynamic shape (NVIDIA#1721)" This reverts commit 5d01ef2. Signed-off-by: Phuong Nguyen <[email protected]>
* Implemented GroupedDense and TestGroupedDense for BF16, FP16, and FP8 * Fix GroupedGemmFFI cuBLAS workspace alignment bug Signed-off-by: Phuong Nguyen <[email protected]> --------- Signed-off-by: Phuong Nguyen <[email protected]> Co-authored-by: Hua Huang <[email protected]>
…#1864) * Support L2Norm basic op Signed-off-by: Evgeny <[email protected]> * Add L2Norm module wrapper Signed-off-by: Evgeny <[email protected]> * Expose qk_norm to MHA nd transformer laayer Signed-off-by: Evgeny <[email protected]> * Move tests into separate file Signed-off-by: Evgeny <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix pass Signed-off-by: Evgeny <[email protected]> * Add license Signed-off-by: Evgeny <[email protected]> * Remove module Signed-off-by: Evgeny <[email protected]> * Resollve comments Signed-off-by: Evgeny <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Evgeny <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…t test (NVIDIA#1873) Distinguish the reasons why fp8 is not supported and mxfp8 is not supported Signed-off-by: Hua Huang <[email protected]>
* fixes for jittable grouped_quantize * fixes for jittable grouped_gemm * fix contracting_dim for wgrad gemm * exclude jitted grouped_gemm from the unit test as it does not work cudaGraph --------- Signed-off-by: Phuong Nguyen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add support for overlapping wgrad NCCL AG with dgrad GEMM Signed-off-by: djns99 <[email protected]> * Remove unused wait on memcpy API from UB Signed-off-by: djns99 <[email protected]> * Add better commenting to MXFP8 overlap Signed-off-by: djns99 <[email protected]> --------- Signed-off-by: djns99 <[email protected]> Co-authored-by: dastokes <[email protected]>
…nit__` (NVIDIA#1870) * Flatten basic op params during fuser init Signed-off-by: Jan Bielak <[email protected]> (cherry picked from commit 949abe97070721b1da5117903067608250f5fb61) * Add caching for is_non_tn_fp8_gemm_supported Signed-off-by: Jan Bielak <[email protected]> (cherry picked from commit fd830ae24ffbd2d0727010b1a8a119ca72f61ce5) * Pass fuser to _OperationFuserAutogradFunction.forward and moving computation to __init__ Signed-off-by: Jan Bielak <[email protected]> (cherry picked from commit fd808991993958b670726896254b82fcb967fa07) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Pass basic_op_kwargs and is_grad_enabled as parameters rather than in fuser Signed-off-by: Jan Bielak <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Jan Bielak <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <[email protected]>
… column-wise usage (NVIDIA#1847) * Do not initialize quantized weights with column-wise usage in inference mode Signed-off-by: Tim Moon <[email protected]> * Fix bug in test Signed-off-by: Tim Moon <[email protected]> * Use no-grad mode instead of inference mode in tests Co-authored-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: Tim Moon <[email protected]> --------- Signed-off-by: Tim Moon <[email protected]> Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
…VIDIA#1858) * Add FP8 current scaling to te.Sequential tests Signed-off-by: Tim Moon <[email protected]> * Helper function for test/ref tensors does not produce quantized tensor by default Signed-off-by: Tim Moon <[email protected]> * Add FP8 current scaling to distributed te.Sequential tests Signed-off-by: Tim Moon <[email protected]> * Add FP8 current scaling to Userbuffers te.Sequential tests Signed-off-by: Tim Moon <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Debug MXFP8 tests Signed-off-by: Tim Moon <[email protected]> --------- Signed-off-by: Tim Moon <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Added support of FP4 data type Signed-off-by: Oleg Goncharov <[email protected]> * Refactoring to BitsNum in progress Signed-off-by: Oleg Goncharov <[email protected]> * Fixed compilation errors. All C++ tests passed Signed-off-by: Oleg Goncharov <[email protected]> * Fixed a typo Signed-off-by: Oleg Goncharov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added FP4 guard to TMA tensor descriptor data type Signed-off-by: Oleg Goncharov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed errors in JAX C++ extensions Signed-off-by: Oleg Goncharov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removed dummy NVFP4 C++ test file Signed-off-by: Oleg Goncharov <[email protected]> * Make pytorch changes Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Refactored the code per the review notes. Fixed JAX build error. Signed-off-by: Oleg Goncharov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removed unnecessary static casts Signed-off-by: Oleg Goncharov <[email protected]> * Typo fix Signed-off-by: Oleg Goncharov <[email protected]> * Pass correct num bits to create_2D_tensor_map; fixes CI Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * inline funcs Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Oleg Goncharov <[email protected]> Signed-off-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: Oleg Goncharov <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
* add support for head dim > 128 Signed-off-by: Charlene Yang <[email protected]> * remove debugging Signed-off-by: Charlene Yang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * raise tols slightly to tolerate 1/2048 mismatches Signed-off-by: Charlene Yang <[email protected]> * fix is_training for test_te_layer Signed-off-by: Charlene Yang <[email protected]> * add bprop support for blackwell Signed-off-by: Charlene Yang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * minor tweak for format Signed-off-by: Charlene Yang <[email protected]> * fix backend selection results Signed-off-by: Charlene Yang <[email protected]> * bump sm100 to sm100+ Signed-off-by: Charlene Yang <[email protected]> * add sq=1 test for MLA Signed-off-by: Charlene Yang <[email protected]> * enable sq=1 for bprop Signed-off-by: Charlene Yang <[email protected]> * minor tweak in comments Signed-off-by: Charlene Yang <[email protected]> * fix head_dim logic and remove pytest skip Signed-off-by: Charlene Yang <[email protected]> * add FE fix for d>128 Signed-off-by: Charlene Yang <[email protected]> * update FE again to take in small fixes Signed-off-by: Charlene Yang <[email protected]> * add cuDNN version info in L0 tests Signed-off-by: Charlene Yang <[email protected]> * increase tols for Unfused + large dim Signed-off-by: Charlene Yang <[email protected]> * Revert "add cuDNN version info in L0 tests" This reverts commit 3e1b426. Signed-off-by: Charlene Yang <[email protected]> * fix tols for Unfused Signed-off-by: Charlene Yang <[email protected]> --------- Signed-off-by: Charlene Yang <[email protected]> Signed-off-by: Charlene Yang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…A#1851) * Add support for Fused Attn MLA head_dim_qk != head_dim_v Modify is_fused_attn_kernel_available() to accept different head_dims for qk and v Modify FusedAttnHelper to accept different head_dims for qk and v and modify assert dims checks in parse_qkv_aval() Modify FusedAttnFwdPrimitive and FusedAttnBwdPrimitive to accept different head_dims for qk and v Modify Fused Attn related cpp and csrc extension API calls to accept different head_dims for qk and v Modify DotProductAttention call() to extract head dims separately for qk and v Modify the FusedAttn Tests to accommodate for API changes in FusedAttn API Add test case for head_dim_qk != head_dim_v (failing) Modify the baseline JAX appropriately to reshape the output vector based on v dims and not q dims Signed-off-by: Kshitij Janardan Lakhani <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix context dims in general DPA in test_fused_attn Signed-off-by: Kshitij Janardan Lakhani <[email protected]> * Fix dim for output tensor by replacing with v head dim rather than q head dim Add test cases for jax fused attn where head_dim_qk != head_dim_v for a combination of data types and attention type Signed-off-by: Kshitij Janardan Lakhani <[email protected]> * Modify the fused attn jax unit test case for head dim qk != head dim v Signed-off-by: Kshitij Janardan Lakhani <[email protected]> * Use new FusedAttnRunner function signature for separate hidden dim for qk and v in Fused Attn distributed tests Code clean up Signed-off-by: Kshitij Janardan Lakhani <[email protected]> * Fix usage of is_fused_attn signature in distributed tests Signed-off-by: Kshitij Janardan Lakhani <[email protected]> * Remove unnecessary assert Signed-off-by: Kshitij Janardan Lakhani <[email protected]> --------- Signed-off-by: Kshitij Janardan Lakhani <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Przemek Tredak <[email protected]>
…VIDIA#1871) * Support MXFP8 and handle empty matrices Signed-off-by: Hua Huang <[email protected]> --------- Signed-off-by: Hua Huang <[email protected]>
* Fix an issue when mcore uses te fusion ce implementation Signed-off-by: lit <[email protected]> * simplify unit test code Signed-off-by: lit <[email protected]> * Update tests/pytorch/test_parallel_cross_entropy.py Signed-off-by: Tim Moon <[email protected]> --------- Signed-off-by: lit <[email protected]> Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Tim Moon <[email protected]>
* include previously accidentally excluded tests * Execute run_test_multiprocessing_encoder with nested bash + exit code for inner bash shell * Adapt run_test_multiprocessing to handle segfault Signed-off-by: Phuong Nguyen <[email protected]> --------- Signed-off-by: Phuong Nguyen <[email protected]>
…1844) * TensorUsage + FP8 GEMM with all layouts handling on BW Signed-off-by: Phuong Nguyen <[email protected]> --------- Signed-off-by: Phuong Nguyen <[email protected]>
…IA#1831) * Use FP16 tols for tests with TF32 Signed-off-by: Tim Moon <[email protected]> * Use uniform init instead of constant init Signed-off-by: Tim Moon <[email protected]> * Revert constant init test, but reduce value Signed-off-by: Tim Moon <[email protected]> --------- Signed-off-by: Tim Moon <[email protected]> Signed-off-by: Tim Moon <[email protected]>
* Fix cppunittest test.sh for editable installs Signed-off-by: Jeremy Berchtold <[email protected]> * Update tests/cpp/CMakeLists.txt Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fixes Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Jeremy Berchtold <[email protected]> Signed-off-by: Kirthi Shankar Sivamani <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
…1793) * finish python ref impl for bulk alloc Signed-off-by: zhongboz <[email protected]> * c++ bulk alloc worked, still draft version Signed-off-by: zhongboz <[email protected]> * clean up Signed-off-by: zhongboz <[email protected]> * resolve rebase conflict Signed-off-by: zhongboz <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add license Signed-off-by: zhongboz <[email protected]> * use shared_ptr to auto manage reference count Signed-off-by: zhongboz <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * attempt to fix misc training error Signed-off-by: zhongboz <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * attempt to handle case where experts get zero token Signed-off-by: zhongboz <[email protected]> * updated with fused C++ function calls Signed-off-by: zhongboz <[email protected]> * clean up Signed-off-by: zhongboz <[email protected]> * experiment with reducing py object construction time Signed-off-by: zhongboz <[email protected]> * fix seg fault bug in inference mode Signed-off-by: zhongboz <[email protected]> * fix lint Signed-off-by: zhongboz <[email protected]> * fuse torch split into bulk alloc Signed-off-by: zhongboz <[email protected]> * clean up Signed-off-by: zhongboz <[email protected]> * rebase to latest main Signed-off-by: zhongboz <[email protected]> * fix unit test failure Signed-off-by: zhongboz <[email protected]> * fix lint error Signed-off-by: zhongboz <[email protected]> * refactor create_tensor to use get_scale_shape Signed-off-by: zhongboz <[email protected]> * refactor quantize to call quantize_cpp Signed-off-by: zhongboz <[email protected]> * Implement separate functions for multi-tensor quantize and split + multi-tensor quantize Signed-off-by: Tim Moon <[email protected]> * Update grouped linear module with fused split+quantize func Signed-off-by: Tim Moon <[email protected]> * Move multi-tensor quantize func to cast.cpp Signed-off-by: Tim Moon <[email protected]> * Do not expose quantizer helper function externally Signed-off-by: Tim Moon <[email protected]> * Fix linter warnings Signed-off-by: Tim Moon <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert cuDNN frontend commit Signed-off-by: Tim Moon <[email protected]> * fix corner cases with zero tokens Signed-off-by: zhongboz <[email protected]> * add comments Signed-off-by: zhongboz <[email protected]> --------- Signed-off-by: zhongboz <[email protected]> Signed-off-by: Tim Moon <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <[email protected]>
* [PyTorch|common] Implement unpadding kernel for FP8 1. Add multi-tensor unpadding kernel 2. Replace split+cat with unpadding kernel in Fp8Padding and Fp8Unpadding 3. Add unpadding with padding unit tests Signed-off-by: xiaoxi-wangfj <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add license Signed-off-by: Xin Yao <[email protected]> * Update padding.cu Signed-off-by: Xin Yao <[email protected]> --------- Signed-off-by: xiaoxi-wangfj <[email protected]> Signed-off-by: Xin Yao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xin Yao <[email protected]>
* fix Signed-off-by: Pawel Gadzinski <[email protected]> * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Pawel Gadzinski <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…VIDIA#1843) * fixed the bug Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * lint fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * test change Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Pawel Gadzinski <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…#1898) Use keyword args for jit in_shardings and out_shardings Signed-off-by: Jeremy Berchtold <[email protected]>
* skip kv cache for sm89, cudnn < 9.12 Signed-off-by: Charlene Yang <[email protected]> * fix test_numerics Signed-off-by: Charlene Yang <[email protected]> --------- Signed-off-by: Charlene Yang <[email protected]>
* fix: (1) UT ignores MLA; (2) bshd format runtime error. Ban fp8 mla attn + cp due to correctness problem Signed-off-by: Yuzhong Wang <[email protected]> * only disable FP8 CP for MLA Signed-off-by: Charlene Yang <[email protected]> --------- Signed-off-by: Yuzhong Wang <[email protected]> Signed-off-by: Charlene Yang <[email protected]> Co-authored-by: Charlene Yang <[email protected]>
fanshiqing
force-pushed
the
v2.5based_dev
branch
2 times, most recently
from
July 30, 2025 07:29
7f0abd7 to
9595f51
Compare
…ted patterns; - ag->fc2_wgrad - ag->fc1_wgrad - fc1_dgrad->rs - ag->proj_wgrad - ag->qkv_wgrad - qkv_dgrad->rs
fanshiqing
force-pushed
the
v2.5based_dev
branch
from
July 31, 2025 02:15
9595f51 to
c58598f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: