name an object as the subject only when it holds what was stored - #80
Merged
rikvanriel merged 1 commit intoAug 28, 2026
Conversation
`request_irq(adapter->pdev->irq, e1000_intr, IRQF_SHARED, netdev->name, netdev)` was reported as attaching the handler to net_device::name. It passes a member of an object, which is the shape an attachment takes, but that member is the string the interrupt is named after and the handler never goes near it. An object is the subject when it holds the thing the callee stored into: `call_rcu(&inode->i_rcu, cb)` passes an rcu_head, the callback lands in rcu_head::func, and inode::i_rcu is declared as an rcu_head. Check that, and the wrong claim goes away while the RCU ones stay. Assisted-by: claw:claude-opus-5 Signed-off-by: Rik van Riel <[email protected]>
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request_irq(adapter->pdev->irq, e1000_intr, IRQF_SHARED, netdev->name, netdev)was reported as attaching the handler to net_device::name. It passes a member of an object, which is the shape an attachment takes, but that member is the string the interrupt is named after and the handler never goes near it.An object is the subject when it holds the thing the callee stored into:
call_rcu(&inode->i_rcu, cb)passes an rcu_head, the callback lands in rcu_head::func, and inode::i_rcu is declared as an rcu_head. Check that, and the wrong claim goes away while the RCU ones stay.Assisted-by: claw:claude-opus-5