rust-project: allow rust-project to define test runners invocations; less adhoc unit-test mappings - #1398
Open
davidbarsky wants to merge 7 commits into
Open
rust-project: allow rust-project to define test runners invocations; less adhoc unit-test mappings#1398davidbarsky wants to merge 7 commits into
davidbarsky wants to merge 7 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D113418263. (Because this pull request was imported automatically, there will not be any future comments.) |
davidbarsky
force-pushed
the
push-zpnqkourvnln
branch
from
July 23, 2026 20:18
19c6e12 to
4092856
Compare
Wilfred
requested changes
Jul 27, 2026
Wilfred
left a comment
Wilfred
left a comment
Contributor
There was a problem hiding this comment.
I have a concern about compatibility, and could you also split these into three PRs? The seem fairly orthogonal.
| /// This is generic metadata about the target. | ||
| pub(crate) labels: Vec<String>, | ||
|
|
||
| #[serde(flatten)] |
Contributor
There was a problem hiding this comment.
This needs to be both backwards and forwards compatible: we want rust-project to accept both old and new bxl formats. I can't guarantee exactly what commit a user's bxl will be (and the bxl changes land immediately, whereas the rust-project binary takes a little longer on dotslash).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three things:
testsofandunit_test_of.with_rust_workspaceto accept arbitrary globs, not just rooted crates. It also grew exclusions for when paired with globs.Each commit should work independently to account for dotslash rollouts.