Hide console status in quiet mode - #1375
Open
daandemeyer wants to merge 1 commit into
Open
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D112616169. (Because this pull request was imported automatically, there will not be any future comments.) |
daandemeyer
force-pushed
the
push-monyqsutowvk
branch
from
July 18, 2026 11:17
bd0a722 to
ff5ef7f
Compare
Make simple-console command start and final remote execution summaries respect status verbosity. Extend the same behavior to the superconsole final status frame and the post-superconsole Build ID reprint. This allows -v 0,actions to report completed actions in the simple console while remaining silent when a command performs no work. The live superconsole still renders while a command is running, preserving interactive progress without leaving status-only output in scrollback. Declare buck2_memfrag as a recognized workspace cfg so the PR continues to build after the daemon dump watcher landed on main and CI began denying unknown cfg names. Add regression coverage that verifies quiet superconsole status remains visible during normal rendering but is omitted from the final frame. Validated with the buck2_client_ctx superconsole unit tests, a buck2_client Cargo check, rustfmt, and targeted buck2_daemon clippy against current main. Signed-off-by: Daan De Meyer <[email protected]>
daandemeyer
force-pushed
the
push-monyqsutowvk
branch
from
July 21, 2026 19:11
ff5ef7f to
40d4e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make simple-console command start and final remote execution summaries respect
status verbosity. Extend the same behavior to the superconsole final status
frame and the post-superconsole Build ID reprint.
This allows -v 0,actions to report completed actions in the simple console
while remaining silent when a command performs no work. The live superconsole
still renders while a command is running, preserving interactive progress
without leaving status-only output in scrollback.
Add regression coverage that verifies quiet superconsole status remains visible
during normal rendering but is omitted from the final frame.
Validated with the buck2_client_ctx superconsole unit tests, a buck2_client
Cargo check, and rustfmt.
Signed-off-by: Daan De Meyer [email protected]