Skip to content

fix(github): accept cache freshness for event polls - #92

Merged
f0rr0 merged 1 commit into
nextfrom
f0rr0/fix-github-event-polling
Aug 31, 2026
Merged

fix(github): accept cache freshness for event polls#92
f0rr0 merged 1 commit into
nextfrom
f0rr0/fix-github-event-polling

Conversation

@f0rr0

@f0rr0 f0rr0 commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • accept GitHub cache freshness as the Events retry interval when a 304 response omits X-Poll-Interval
  • keep explicit malformed poll headers fail-closed
  • cover the exact production 304 response shape and timing bound

Production evidence

  • retained pg_net history contained 62 Events responses with HTTP 503 versus 10 successes
  • the real conditional request reproduced 304 with Cache-Control max-age=300 and no X-Poll-Interval
  • the patched collector handles the same live response as a healthy no-op with a 300-second retry

Validation

  • bun test: 240 passed
  • bun run typecheck
  • bun run lint
  • bun run format:check
  • bunx next build

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
f0rr0-github-io Ready Ready Preview Aug 31, 2026 7:41am

@f0rr0
f0rr0 merged commit 877b530 into next Aug 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant