fix: NPE and incorrect status on WebDAV HEAD for folders EXO-89265 - #2038
Merged
Conversation
HeadWebDavHandler unconditionally read the GETCONTENTTYPE/GETCONTENTLENGTH properties, which are only populated for files, causing a NullPointerException on folders. It also always returned 204 No Content instead of mirroring the 200 OK returned by the equivalent GET. The handler now branches on WebDavItem#isFile(): for a file it still reads Content-Type/Content-Length, now made null-safe through a setHeaderIfPresent helper; for a folder it sets Content-Type to text/html, matching the listing GetWebDavHandler renders for the same resource. The response status is now always 200 OK in both cases, consistent with what GetWebDavHandler returns. (cherry picked from commit 280001d)
houssemexo26
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeadWebDavHandler unconditionally read the GETCONTENTTYPE/GETCONTENTLENGTH properties, which are only populated for files, causing a NullPointerException on folders. It also always returned 204 No Content instead of mirroring the 200 OK returned by the equivalent GET.
The handler now branches on WebDavItem#isFile(): for a file it still reads Content-Type/Content-Length, now made null-safe through a setHeaderIfPresent helper; for a folder it sets Content-Type to text/html, matching the listing GetWebDavHandler renders for the same resource. The response status is now always 200 OK in both cases, consistent with what GetWebDavHandler returns.
(cherry picked from commit 280001d)