Repository navigation
fix(members): fall back to today for age flags when tournament dates are TBD - #98
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚅 Deployed to the nexus-pr-98 environment in nexus
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Age flags showed Unknown for every member of a tournament whose primary tracks have TBD dates, because there was no first day to measure age against. They now fall back to today's date in the tournament's timezone.
What changed
Backend
Logic
TournamentMembership.is_over_18/is_over_21measure age againsttournament.first_day, or today in the tournament's timezone when it'sNone. They'renullonly when the user has no date of birth.seed_membersrecords age disclosure consent when the tournament collects an age flag (--no-age-consentto skip), matching what redeeming a join code does.Out of scope
Test plan
pytestpasses locallyAutomated
test_memberships.py— age flags fall back to today on a TBD tournament.Manual