Repository navigation
feat: edit events and shifts in place, sort members per track - #103
Merged
Merged
Conversation
… shared by the events table and assignments board
…s, chaining in click order
…a column per track
…nd time, with reset in the Display button and modal
…rom an expand button, and add DivisionButtonGroup for every division picker
…firming before a track takes its shifts with it
… deriving floor from the first room unless overridden
…ding, replacing the native datalist
…ed, so the table reads normally at rest
…lls, dropping the expand button
…a panel skips the board
…tead of a router navigation
…us restored after edits, and tracks/shifts at rest until opened
…d's shifts and tracks
…ton-group pickers
…show 'No location'/'No staffing' instead of dashes
…ild only the changed event's board copy
…en editing, and focus a new role's count
… arrows move within them
…onList, with Enter filling in the first match
…ll open its editor
…, so a sliding panel stops re-rendering the table
…t rebuilds no columns
…bar or column headers
…patch that ends before it starts
…ed table edits in a toast instead of under the cell
…act Compiler can optimize the page
… reset, and match the events toolbar
…-based lunch columns, chip the per-track groups, and fold the header; sort shifts by date
…mns to fit instead of truncating, and keep roles wide
…side the viewport
…ing anyone you can't remove
…ity, lunch and event preference rank, picked by category then pills
…dietary, lunch and custom field card fields
…ed crumb, and drop a clicked crumb dropdown's border once you move away
…ent, and backfill existing ones
…he tab-scoped board key, and drop the stale staffing-sort test
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚅 Deployed to the nexus-pr-103 environment in nexus
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #102 — everything on
feat/event-logisticssince it merged.What changed
Backend
Models and migrations
8a438a1a14a3)TournamentEventTrack.effective_floorreturns the floor override if set, else the first character of the first room; no column change.TournamentEvent.nameon a catalog-linked event is now a tournament-level override of the catalog name (comment and docstring only).Schemas and routes
shifts_tablesurface (filterstrack,events; sortslabel,track,date,start,end,duration,events).page_headersurface holding onlycollapsed;collapsedon any other surface is a 422.track,building,shifts,shiftandstaffing; both adddivisionas a sort key.time:<id>keys stay valid.onboardingplus per-track sort fields (track:,availability_track:,event_pref:<track>:<event>,lunch:<track>:<key>).dietary_restrictionand event preferences; lunch columns appear for published lunch questions before anyone answers.onboarding,dietary_restriction,lunchandcustom_fields, withcard_custom:<field_id>to hide one question.PATCH /shifts/{id}rejects a result that ends at or before its start, checked after merging a partial patch.Logic
sync_sole_track_nameruns after tournament renames, track edits and track deletes, so a track rename on a simple tournament is put back rather than refused.effective_floor, so a floor derived from rooms resolves to its floor zone.Frontend
Events
Shifts
Members
RemoveMembersModal).Assignments board
Layout and settings
useSettingsPages,SettingsPageHeader).useHeaderCollapse).Shared UI
OptionListreplaces the separate Dropdown, Combobox and suggestion lists; Enter fills in the first match.DivisionButtonGroupfor every division picker,SortableHeaderfor chained header sorting,PillInput.lib/gridNav.tsfor table cell navigation,lib/memberSort.tsandlib/shiftSort.tsfor sort chains.Badgeuses its own mono font instead of inheriting one.replaceStateinstead of a router navigation.Out of scope
feat/buildings-and-zones.Test plan
pytestpasses locallyAutomated
test_display_config.py: shifts table and page header surfaces, collapsed rejection, per-track member sort fields, new card fields.test_tracks.py: sole track renamed on tournament rename, track edit and delete down to one.test_shifts.py: a patch ending before its start is rejected.test_memberships.py: filtering event preferences by rank.test_zones.py: a floor rule matches the floor derived from the first room, and a typed floor overrides it.Manual