Skip to content

fix(members): members table search crashes when Email and Phone columns are hidden - #101

Merged
ethnjs merged 1 commit into
mainfrom
fix/members-search-email
Oct 3, 2026
Merged

ethnjs merged 1 commit into
mainfrom
fix/members-search-email

Conversation

@ethnjs

@ethnjs ethnjs commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Searching the members table crashed the page ("Application error") when a saved view hid both the Email and Phone columns. The table now always gets email, so search works with any set of columns.

What changed

Backend

Logic

  • The members_table surface now always includes the contact field group, the same way it always includes roles.
  • Before, only the Email and Phone columns pulled in contact, but search and the name fallback read user.email regardless.
  • Fixed here rather than with a frontend ?? "" guard, which would have silently stopped search from matching on email.

Docs

  • Adds the v1.3.1-beta release note.

Test plan

  • pytest passes locally
  • Migration included for every model change
  • Clicked through the UI change in a browser

Automated

  • test_memberships.py: hiding the email column still returns user.email on table rows.

Manual

  • Hide the Email and Phone columns on the members table, type in search: no crash, and a search by email still matches.

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nexus Ready Ready Preview Oct 3, 2026 7:23pm UTC

@railway-app

railway-app Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the nexus-pr-101 environment in nexus

Service Status Web Updated
nexus ✅ Success (View Logs) Oct 3, 2026 at 7:23 pm UTC

@railway-app
railway-app Bot temporarily deployed to nexus / nexus-pr-101 October 3, 2026 19:22 Destroyed
@ethnjs
ethnjs merged commit 81d1075 into main Oct 3, 2026
4 checks passed
@ethnjs
ethnjs deleted the fix/members-search-email branch October 3, 2026 20:15

This branch was successfully deployed

1 active deployment
Preview — 4e510b07 Deployed Oct 3, 2026 by vercel[bot]
nexus / nexus-pr-101 — 4e510b07 Deployed Oct 3, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant