Repository navigation
fix(members): members table search crashes when Email and Phone columns are hidden - #101
Merged
Merged
Conversation
…ch can match on email
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚅 Deployed to the nexus-pr-101 environment in nexus
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Searching the members table crashed the page ("Application error") when a saved view hid both the Email and Phone columns. The table now always gets email, so search works with any set of columns.
What changed
Backend
Logic
members_tablesurface now always includes thecontactfield group, the same way it always includesroles.contact, but search and the name fallback readuser.emailregardless.?? ""guard, which would have silently stopped search from matching on email.Docs
v1.3.1-betarelease note.Test plan
pytestpasses locallyAutomated
test_memberships.py: hiding the email column still returnsuser.emailon table rows.Manual