[spencer-tb]

🗒️ Description

Draft PR to align the EIP-8282 builder deposit pre-deploy to the with the proposed glamsterdam-devnet-7 contract changes.

New mined addresses:

• Builder Deposit Contract: 0x0000BFF46984E3725691FA540A8C7589300D8282 (now using target=8/max=64)
• Builder Exits Contract: 0x000064D678505AD48F8CCB093BC65613800E8282

Both contracts now contain the inhibitor.

🔗 Related Issues or PRs

Part of #3034. Dependent on both ethereum/sys-asm#49 and ethereum/sys-asm#50.

✅ Checklist

• All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Verifying Changes:

  just static

• All: PR title have the form <type>(<area>):, where <type> and <area> come from an approrpriate C-<type>, respectively A-<area>, label. The title should match the a target squash commit message.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (76b7f70) to head (7c4880e).

Additional details and impacted files

@@                 Coverage Diff                 @@
##           forks/amsterdam    #3091      +/-   ##
===================================================
- Coverage            93.30%   92.45%   -0.85%     
===================================================
  Files                  624      624              
  Lines                36988    36988              
  Branches              3384     3384              
===================================================
- Hits                 34510    34197     -313     
- Misses                1695     1909     +214     
- Partials               783      882      +99     

Flag	Coverage Δ
unittests	92.45% <ø> (-0.85%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marioevz]

New mined address 0x00006AE84ed173D4394de5E28F9ED56b28008282, we are now using target=8/max=64.

Where did we get this from? The EIP needs to be updated.

[marioevz]

Looks mostly good to me. Some comments:

• The builder deposit contract address is not in the EIP yet, we need it there for us to be able to merge to forks/amsterdam (We can merge to devnets/glam/7 as you are doing now and release from there)
• The excess fee modifications change the way the system contract tests were originally envisioned. We should correctly refactor the framework to support this instead of doing workarounds IMO

[spencer-tb]

cc @marioevz PTAL: spencer-tb#25