Conversation
SetString("1e") returned 1, and SetString(".") returned 0, without ConversionSyntax. Those strings are now quiet NaNs, like other rejected numeric strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetString("1e")returned1.SetString("1e+")andSetString("1e-")also returned1, andSetString(".")returned0. None of them setConversionSyntax.ConversionSyntax, which is the same path other rejected numeric strings already take.1e2,1e+2,1e-1,1., and.5still parse as before.Test plan
TestSetStringTruncatedNumericfailed on tip:1e = 1, want NaNMade with Cursor