fix(prstatus): ignore CI runs superseded by a newer run of the same job - #310
Merged
Merged
Conversation
A run cancelled by a newer one (concurrency group, manual re-run) stays in statusCheckRollup next to its replacement, and aggregateCI counted its CANCELLED conclusion as a failure, so a green PR showed as failing. Keep only the latest run per workflow+job before aggregating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a workflow is started twice for the same commit and the second run cancels the first (a concurrency group or a manual re-run), GitHub keeps both runs in
statusCheckRollup.aggregateCIcounted the staleCANCELLEDentry as a failure, so a PR where every job passed showed as failing.latestRunsnow keeps only the newest run of each job (by workflow + job name, neweststartedAt) before aggregating:Tests: three new
TestAggregateCIcases, one built from a real PR's rollup. The two cases for the bug fail without the fix. Unit and e2e suites pass with-race -shuffle=on.