Conversation
🦋 Changeset detectedLatest commit: 448dc9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the accessibility gap and reset interaction state when resizing is disabled.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Improves the SideSheet resize affordance with an external handle and clearer hover/drag feedback while documenting disableResize.
Changes:
- Adds a half-circle external resize handle.
- Highlights the handle and sheet border during interaction.
- Documents resize behavior and
disableResize.
Review findings:
- The handle lacks an accessible keyboard and screen-reader interaction.
- Resize and hover state may become stale if
disableResizechanges during interaction.
| File | Summary |
|---|---|
packages/side-sheet/src/components/SideSheetBase.tsx |
Implements the redesigned handle, visual feedback, and resize state handling. |
packages/side-sheet/README.md |
Documents resize behavior and disableResize. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
if we pull it to full width we cant get a hold of the handle again. |
|
@eikeland Updated in the signed, single-commit PR (448dc9c): the resize control is a full-height, 16 px-wide strip outside the SideSheet. At the expanded limit the sheet stops 16 px short, leaving the strip at the viewport left edge so it remains grabbable anywhere along its height. It does not flip inward. The 2 px outer border stays visible in subtle gray; hovering or dragging fills the strip background with that same gray. There is no inner/right border or shadow, and the grip is centered in the full strip with 50% opacity. Keyboard resizing remains available: Left Arrow widens, Right Arrow narrows, Home selects minimum width, and End selects maximum width, following the WAI-ARIA Window Splitter convention. Verified the outside edge at desktop and narrow viewport widths and the final hover background and icon centering in Storybook. |
233d972 to
5d26744
Compare
f93d18c to
d04a221
Compare
d04a221 to
94ecc05
Compare
Co-authored-by: Copilot App <[email protected]>
94ecc05 to
448dc9c
Compare


Component Development
Type
Reference to assignment
Closes equinor/fusion-core-tasks#1860
Description of assignment
Make the SideSheet resize target easier to see and use while retaining dismissal behavior.
Description of Proposed Changes
disableResizealready existed before this PR; do not introduce a new prop or resizing opt-out. Update its README documentation to describe the new strip, preserving its existing purpose of hiding the resize control and disabling resizing.chdefrene-storybook-light-mode.Checklist
Create User Story(DevOps) or Issue(Github)
Development
Validation:
bun run --cwd packages/side-sheet build— passed.bunx biome check packages/side-sheet/src/components/SideSheetBase.tsx packages/side-sheet/src/components/icon/HandlerIcon.tsx— passed.git diff --check— passed.Create Pull Request
Review of Pull Request
Publish Code