Skip to content

fix(layout): support page props in stories - #3385

Merged
eikeland merged 5 commits into
mainfrom
fix/layout-page-props
Sep 2, 2026
Merged

eikeland merged 5 commits into
mainfrom
fix/layout-page-props

Conversation

@eikeland

@eikeland eikeland commented Sep 1, 2026 •

Copy link
Copy Markdown
Collaborator

Component Development

Type

  • Feature
  • Fix
  • Hotfix (should release ASAP)
  • Maintenance (deps only)

Reference to assignment

N/A

Description of assignment

Ensure layout stories use the full preview height and allow Page and its slot compound components to receive standard React element props, including ref.

Description of Proposed Changes

  • Render layout stories inside a 100vh Storybook decorator.
  • Forward root Page props to fwc-page and expose PageProps.
  • Forward props to page slot containers while retaining their assigned slots.

Checklist

Create User Story(DevOps) or Issue(Github)

  • Describe functional requirements
  • Design plan/suggestion (e.g. images, link to eds design or relevant figma links, mention of eds tokens to use)
  • Communication with UX (evaluate if needed)

Development

  • Describe the component
  • Code funtional requirements
  • Create stories
  • Create snapshots (evaluate if needed)
  • Remove unused imports and commented code
  • Lint code with Biome (and follow best practises for code quality)

Validation: bun run --cwd storybook build

Create Pull Request

  • Assign relevant reviewers in Github and Cromatic
  • Inform colleagues of pending reviews. We use Teams for this purpose, under fusion-frontend team please tag involved reviewers in the Code review channel

Review of Pull Request

  • Follow up on comments from code review and implement necessary changes (evaluate if needed)
  • Review approved in github (and chromatic)

Publish Code

  • Increment version number
  • Merge PR
  • Consider letting fusion developers know this this shiny new thing exists

@changeset-bot

changeset-bot Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9955577

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-react-layout Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland
eikeland marked this pull request as ready for review September 2, 2026 07:07
@eikeland
eikeland merged commit 934e52c into main Sep 2, 2026
5 of 7 checks passed
@eikeland
eikeland deleted the fix/layout-page-props branch September 2, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants