Repository navigation
Fix silent Save/Share logs failure on macOS/iOS - #463
Merged
Merged
Conversation
added 3 commits
October 19, 2026 17:20
flutter-settings-ui now wraps the value widget in Flexible+DefaultTextStyle instead of placing it directly inside a Flex, so the iOS-only Expanded(child: Row(...)) wrapping in _getRuntimeIdForOS no longer has a valid Flex ancestor and throws. The package already handles shrinking and ellipsis itself, so the extra wrapping is removed for all platforms.
…/iOS log.dart's dump() called file.parent.list() unconditionally; on macOS/iOS the logs directory never existed (Logtee wasn't bundled there), so it threw, and since the UI calls _saveLogs/_shareLogs via unawaited(), the failure was completely silent - tapping "Save" just did nothing. - log.dart: return early from dump() if the logs directory doesn't exist. - Bump the ouisync submodule to pick up Logtee.framework support for macOS/iOS, so the logs directory and log file now actually exist there too. - Podfile.lock (macOS, iOS): updated by pod install for the new logtee pod.
panfilov-vladislav
force-pushed
the
logtee-macos-ios
branch
from
October 20, 2026 00:20
4ef1b32 to
ccb15fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log.dart'sdump()calledfile.parent.list()unconditionally, but the logs directory never existed on those platforms (the nativelogteelibrary wasn't bundled there). Since the UI invokes_saveLogs/_shareLogsviaunawaited(), the resulting exception had nowhere to go — tapping "Save" just produced no visible effect.log.dart:dump()now returns early if the logs directory doesn't exist, instead of throwing.ouisyncsubmodule to pick up Logtee.framework support for macOS/iOS (see companion PR [equalitie/ouisync#TODO]), so the logs directory and log file now actually exist on those platforms too — not just a crash fix, but real persisted logging.macos/Podfile.lock,ios/Podfile.lock: updated bypod install/flutter pub getfor the newlogteepod.Why
Save/Share logs is a user-facing diagnostic feature; on macOS/iOS it was fully broken with no error surfaced.