Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
React Doctor found 2 new issues in 1 file · 2 warnings · score 86 / 100 (Great) · 0 fixed · vs 2 warnings
Reviewed by React Doctor for commit |
| @@ -172,10 +178,14 @@ function rowMatches(item: EarnMarketRow, query: string): boolean { | |||
|
|
|||
| export function MarketPickerPage({ | |||
There was a problem hiding this comment.
React Doctor · react-doctor/no-high-complexity-react-function (warning)
MarketPickerPage has cyclomatic complexity 18, cognitive complexity 23, and maximum nesting depth 4, so its React logic is hard to understand and change. Extract independent branches into components or hooks.
Fix → Extract independent render branches and state logic into focused components or hooks until the control flow is easy to follow.
|
|
||
| export function MarketPickerPage({ | ||
| rows, | ||
| vaults = [], |
There was a problem hiding this comment.
React Doctor · react-doctor/rerender-memo-with-default-value (warning)
This reruns hooks that list it in their dependency array because default prop value [] makes a brand new array every render, so move it to a constant at the top of the file
Fix → Move it to the top of the file: const EMPTY_ITEMS: Item[] = [], then use that as the default value
Summary
Dependencies:
This PR preserves the widget's original port configuration; fresh local port wiring is excluded.
Verification