EPMDEDP-17257: refactor: Remove dead git methods and vestigial CodebaseBranch workdir cleanup - #309
Merged
Conversation
…seBranch workdir cleanup Cleanup of code left with zero call sites once CodebaseBranch git operations moved to packless transport. - Drop Fetch, CommitExists and CreateRemoteTag from the Git interface and GitProvider. None had a production caller, and Fetch carried a latent bug: its per-branch refspec lacked a force prefix and wrote straight into local branch refs, so any future caller would fail on a diverged branch. - Remove the clean_tmp_directory chain step and the branch controller's directory cleanup on deletion. Neither path can do anything useful because the CodebaseBranch chain no longer creates a working directory; only the Codebase chain does, and its own cleanup is untouched. - Regenerate mocks and drop the tests that covered the removed methods. Signed-off-by: Sergiy Kulanov <[email protected]>
Collaborator
Pipeline
|
| Status | Task | Duration |
|---|---|---|
| ✅ | github-set-pending-status | 6s |
| ✅ | fetch-repository | 7s |
| ✅ | init-values | 5s |
| ✅ | get-cache | 2m13s |
| ✅ | commit-validate | 5s |
| ✅ | dockerfile-lint | 8s |
| ✅ | helm-lint | 6s |
| ✅ | helm-docs | 11s |
| ✅ | build | 56s |
| ✅ | sonar | 16s |
| ✅ | save-cache | 7s |
| ✅ | buildkit-build | 20s |
| ✅ | github-report-pipeline-status | 7s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of code left with zero call sites once CodebaseBranch git operations moved to packless transport.