Repository navigation
Nodes page: don't hide producers whose nodes are all producer nodes - #4
Merged
Merged
Conversation
sortNodes merged every node whose first type is "producer" into one Producer card, but only added that card when the producer also had another node. panshieosbp1's single node is producer, query and seed at once, so it was merged away and the producer was left out of the Nodes page. Only producer-only nodes are merged into the Producer card now; a node with extra roles is shown as its own card (titled e.g. "Producer, Query, Seed", with its endpoints), and a producer with only producer-only nodes still gets its Producer card. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Nodes page: don't hide producers whose nodes are all producer nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Rossco99/antelope-tools#24.
panshieosbp1 didn't show up on Jungle's Nodes page. The page merged every node whose first type is "producer" into one Producer card, and added that card only when the producer had another node. Panshi's single node is producer, query and seed at once, so the whole producer was skipped.
The change:
Passed the build-and-smoke CI on the fork. On a production build of Jungle, the Nodes page lists 8 producers (previously 7), including EOS Panshi.
🤖 Generated with Claude Code