client: always emit request_body_size in toCommandLineOptions() - #1599
Open
bpalermo wants to merge 1 commit into
Open
client: always emit request_body_size in toCommandLineOptions()#1599bpalermo wants to merge 1 commit into
bpalermo wants to merge 1 commit into
Conversation
request_options.request_body_size was only set inside the loop over the configured request headers, so a --request-body-size without any --request-header was dropped from the CommandLineOptions proto (and thus from executions routed through the gRPC service). Hoist it out of the loop and add a test. Signed-off-by: Bruno Palermo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to #1606
request_options.request_body_sizewas only set inside the loop over the configured request headers, so--request-body-sizewithout any--request-headerwas dropped from theCommandLineOptionsproto, and therefore from executions routed through the gRPC service (--nighthawk-service). This hoists it out of the loop.Notes for Reviewers
New test
OptionsImplTest.RequestBodySizeIsEmittedWithoutRequestHeaderscovers the proto round trip;//test:options_testpasses. Version history updated.