client: log the tunneling startup exception instead of printing it to stdout - #1598
Open
bpalermo wants to merge 1 commit into
Open
client: log the tunneling startup exception instead of printing it to stdout#1598bpalermo wants to merge 1 commit into
bpalermo wants to merge 1 commit into
Conversation
… stdout When the encapsulating Envoy fails to start, the exception was written to std::cout in addition to the logger. stdout is where nighthawk_client writes its formatted result, so consumers that parse it (e.g. JSON) saw a stray line in the error case. Log it only. Signed-off-by: Bruno Palermo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to #1605
When the encapsulating Envoy fails to start on the tunneling path, the exception was written to
std::coutin addition to the logger. stdout is wherenighthawk_clientwrites its formatted result, so consumers that parse it (for example--output-format json) could see a stray line in that error case. This logs it only.Notes for Reviewers
One-line logging change on an error path; builds. Version history updated. Signed off per the DCO.