fix(conformance): free_node died whenever a matching card was actually listed - #1731
Merged
Conversation
…y listed Inside jq's contains(), `.` is the string being searched, so the `taken` test's bare `.id` indexed $taken (a string) instead of the executor. `and` short-circuits, so the clause was only ever reached when an executor had already matched gpu_type, gpu_count, vram and download — that is, the filter failed precisely when it found a card, and looked fine on every listing that had none. The element is bound to $n before the test. Entries that are not objects, or that are missing a field, are skipped rather than aborting the run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/serving_conformance_on_lium.shcould never rent a pod.Inside jq's
contains(),.is the string being searched — so inthe
.idwas indexed on$taken, a string, givingjq: error: Cannot index string with string "id"and exit 5.Because
andshort-circuits, that clause is only reached once an entry has already matchedgpu_type,gpu_count,vram_gbanddownload_mbps— so the filter failed exactly when a 5090 was available, and looked healthy on every listing where none were. Reproduced against a live listing: the run dies ~2 s in, before renting anything.Binds the element to
$nfirst, and skips non-object / field-missing entries instead of aborting — the listing churns and one malformed entry should not cost the rental.Verified against a captured live listing: two distinct 5090 ids are selected, and the second correctly excludes the first.
Found while running the conformance job after setting
LIUM_API_KEY— with the key in place this was the next failure. No pods were rented in any of the failed runs.