Skip to content

fix: implement table:"-" field exclusion - #7

Merged
masonkatz merged 3 commits into
mainfrom
fix/skip-tag-fields
Aug 22, 2026
Merged

fix: implement table:"-" field exclusion#7
masonkatz merged 3 commits into
mainfrom
fix/skip-tag-fields

Conversation

@masonkatz

Copy link
Copy Markdown
Member

Summary

  • omit fields tagged with table:"-" from text tables
  • preserve correct spacing when a skipped or empty column is last
  • document and test that JSON and YAML retain original struct fields

Fixes #3

Validation

  • make test
  • make lint (currently reports five pre-existing goconst findings on origin/main)

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (ab3a1e6) to head (625b66f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   80.76%   81.60%   +0.83%     
==========================================
  Files           8        8              
  Lines         286      299      +13     
==========================================
+ Hits          231      244      +13     
  Misses         51       51              
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@masonkatz
masonkatz force-pushed the fix/skip-tag-fields branch from 724dff6 to 472a6c5 Compare August 22, 2026 01:29
@masonkatz

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict in text.go — the annotationsFor function from main was merged alongside the lastVisibleColumn/visible additions from this branch. All tests pass (commit 625b66f).

@masonkatz
masonkatz merged commit bcb21a0 into main Aug 22, 2026
2 checks passed
@masonkatz
masonkatz deleted the fix/skip-tag-fields branch August 23, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: implement table:"-" field exclusion

2 participants