Skip to content

Generalize delivery activity branding - #1

Draft
ali-20 wants to merge 5 commits into
mainfrom
agent/generalize-live-activity
Draft

Generalize delivery activity branding#1
ali-20 wants to merge 5 commits into
mainfrom
agent/generalize-live-activity

Conversation

@ali-20

@ali-20 ali-20 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Replaces YALLA-specific Android service, style, preference, channel, and log identifiers with neutral or package-scoped values.
  • Adds optional start-payload configuration for app scheme, primary/accent colors, and logo/rider drawable names.
  • Keeps the existing native method signatures and YALLA values as fallback defaults for backward compatibility.
  • Packages the Enatega logo and rider drawables used by Enatega’s configured resource names.

Why

The module is now reusable by Enatega without hard-coded YALLA branding or package-level storage collisions, while YALLA remains pinned to its existing immutable commit.

Impact

Enatega pins commit 36282d6ccf24c9e8095a2b82d56668d55c9ecf59 and passes its branding configuration. Existing consumers retain the same JavaScript/native API and fallback presentation.

Validation

  • Enatega resolves the exact remote Git commit through package.json and package-lock.json.
  • Both Enatega Android drawables are present in the installed package.
  • Expo Android prebuild passed against the remote dependency.
  • :app:compileDebugKotlin passed, including the remote activity-controller module.
  • Repository diff/whitespace checks passed.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ad89a75a-4d29-4f7a-98d7-92866b97f8e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/generalize-live-activity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant