Skip to content

feat: rewrite observability skill as vendor-neutral OpenTelemetry pipeline - #16

Merged
emmadal merged 1 commit into
mainfrom
feat/observability-skill-v2
Nov 12, 2026
Merged

emmadal merged 1 commit into
mainfrom
feat/observability-skill-v2

Conversation

@emmadal

@emmadal emmadal commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replaces the generic 24-line observability skill with a dense core (218 words) plus four on-demand references, verified against opentelemetry.io at writing time.
  • Vendor-neutral OTel-first: OpenTelemetry SDK -> OTLP -> Collector/gateway -> any backend; legacy patterns (StatsD, Jaeger UDP, Zipkin, Promtail, vendor SDKs in code, deprecated semconv keys) are explicitly banned with modern replacements.

Changes

  • .agents/skills/observability/SKILL.md: setup order, hard rules (cardinality, sampling, PII, collector guardrails), legacy ban, verify drill.
  • references/guide.md: 4-signal pipeline, agent/gateway topology, head+tail sampling config, cost/cardinality guards, legacy->modern table.
  • references/backends.md: OTel setup for Python, Node/TS, Go, Java, .NET, Rust, PHP, Ruby with official doc links.
  • references/semantic-conventions.md: stable HTTP/DB attribute names, old->new migration tables, messaging/GenAI status.
  • references/slo-and-alerts.md: SLIs, multi-window burn-rate pairs, dashboard golden signals, runbook template, health probes.
  • Mirrors regenerated (skills/, .claude/skills/).

Testing

  • validate_skills, sync_agents, route_eval (97.9% rank-1, top-3 100%, 47/47 negatives), token_report within budget, pytest 156 passed (coverage 94.25%), ruff, bandit, pip-audit clean.
  • Independent reviewer pass: verified semconv/env/collector claims against current docs; 5 findings fixed (burn-rate window pair, client span name, env-var scope note, otelsql attribution, identity wording).

Replace the generic 24-line skill with a dense core plus four verified
references: collector topology and sampling (guide), per-language setup
for 8 backends (backends), stable semconv names with legacy mappings
(semantic-conventions), and SLOs/burn-rate alerts (slo-and-alerts).
Legacy patterns are explicitly banned with modern replacements.
Description kept within the 9000-char catalog budget.
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@emmadal
emmadal merged commit bf725a4 into main Nov 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant