Repository navigation
feat: rewrite observability skill as vendor-neutral OpenTelemetry pipeline - #16
Merged
Merged
Conversation
Replace the generic 24-line skill with a dense core plus four verified references: collector topology and sampling (guide), per-language setup for 8 backends (backends), stable semconv names with legacy mappings (semantic-conventions), and SLOs/burn-rate alerts (slo-and-alerts). Legacy patterns are explicitly banned with modern replacements. Description kept within the 9000-char catalog budget.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
.agents/skills/observability/SKILL.md: setup order, hard rules (cardinality, sampling, PII, collector guardrails), legacy ban, verify drill.references/guide.md: 4-signal pipeline, agent/gateway topology, head+tail sampling config, cost/cardinality guards, legacy->modern table.references/backends.md: OTel setup for Python, Node/TS, Go, Java, .NET, Rust, PHP, Ruby with official doc links.references/semantic-conventions.md: stable HTTP/DB attribute names, old->new migration tables, messaging/GenAI status.references/slo-and-alerts.md: SLIs, multi-window burn-rate pairs, dashboard golden signals, runbook template, health probes.skills/,.claude/skills/).Testing
validate_skills,sync_agents,route_eval(97.9% rank-1, top-3 100%, 47/47 negatives),token_reportwithin budget,pytest156 passed (coverage 94.25%),ruff,bandit,pip-auditclean.