Repository navigation
feat(skills): tighten discover and incremental-implementation; 30/30 perfect on re-run - #12
Merged
Merged
Conversation
…perfect on re-run - incremental-implementation: an existing test suite is not an exemption; extend the nearest test file (fixes scope_tests test_added failures) - discover: the first reply is questions, not a plan (fixes vague asked_questions failure); fixes duplicated numbering - expo/expo-ui: @expo/ui defaults for sheets, pickers, sliders, toggles, menus, grouped forms; List is not virtualized - behavioral re-run n10 Sonnet: scope_tests 10/10 (was 7/10), vague 10/10 (was 9/10); combined with tdd 10/10 = 30/30 perfect (100%) - benchmarks doc: discloses the invalid first attempt (system python lacked pytest)
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
incremental-implementationno longer lets an existing test suite exempt a slice from a new test (3 failedscope_testsruns), anddiscovermakes the first reply questions-only (1 failedvaguerun).@expo/uias default for sheets/pickers/sliders/toggles/menus/grouped forms,Listis not a virtualized list.Changes
.agents/skills/{incremental-implementation,discover,expo}+ generated.claudemirrorevals/behavioral/results-scope-tests-venv-n10.json,results-scope-vague-n10.json: new runsdocs/benchmarks.md: dated section with numbers and the invalid-first-attempt disclosureTesting
scope_testsours 10/10 perfect (was 7/10; upstream 0/10),vagueours 10/10 (was 9/10). Combined with unchangedtdd10/10: 30/30 = 100%.validate_skillsOK ·sync_agents --checkOK · pytest 78 passed (93.91%)