Updates - #10
Open
jflowernet wants to merge 2 commits into
Open
Updates#10jflowernet wants to merge 2 commits into
jflowernet wants to merge 2 commits into
Conversation
…all examples, tests and readme's now use internal data rather than relying on downloaded data using oceandatr
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update makes patchwise compatible with the latest versions of prioritizr, fixing the issue detailed here. This involved only a small change to code, switching column names from "id" to "idx".
The more significant body of work is that the readme, vignette, examples and tests all now use internal data rather than having to download data using
oceandatr. This reduces the dependencies, makes checking and testing a lot quicker, and also makes patchwise more generic - a good thing since it is not intended just for users of oceandatr.@echelleburns if you have time/ energy in the next couple of weeks, and you would like to review, feel free, otherwise you can tick and merge! Would be great if you could do a quick
devtools::check()on your machine. I get no errors, just 2, fairly insignificant, notes.