Conversation
ebuild test already preferred a PATH ninja binary and fell back to python -m ninja. ebuild build still hardcoded the module form, so a system ninja install was not enough for the main command. Fixes embeddedos-org#159 Signed-off-by: agayushh <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ebuild test already preferred a PATH ninja binary and fell back to python -m ninja. ebuild build still hardcoded the module form, so a system ninja install was not enough for the main command.
Fixes #159
Summary
Wire
ebuild buildtoninja_command()(same helperebuild testalreadyuses) and update README.md / demo.md, which still said the pip
ninjapackage was required because ebuild always invoked
python -m ninja.Type of Change
Changes
ebuild/cli/commands.py:ebuild buildnow callsninja_command()instead of[sys.executable, "-m", "ninja", ...]README.md,demo.md: document PATH ninja first, pip module as fallbackCHANGELOG.md: record the fixtests/unit/test_ninja_command.py: unit tests for the helper and for theebuild buildargvTesting
ctest --test-dir build --output-on-failure)Pre-Submission Checklist
-Wall -Wextra -Werrorfor C)<type>(<scope>): <description>conventionmasterRelated Issue
Fixes #159
Screenshots / Logs
python -m pytest tests/unit/test_ninja_command.py -v --tb=short
4 passed in 0.08s
python -m pytest tests/unit/test_dispatch.py tests/unit/test_doctor.py tests/unit/test_documented_commands_exist.py tests/ebuild/test_build_cli.py tests/unit/test_build_failure_output.py -v --tb=short
33 passed in 0.20s
python -m ruff check ebuild/cli/commands.py tests/unit/test_ninja_command.py
All checks passed
cd examples/hello_world
ebuild build
./_build/hello
Hello from EoS Build System!
Additional Notes
I did not rewrite
commands.pyline endings. That file is already CRLF in the repository;git diff --checkflags\ron newly added lines for that reason.