Repository navigation
Conversation
Moves rpc_call, rpc_payment_tests, webhook and webhook_delivery into crates/erpc/src/rpc/, the third step of the module restructure after cli/ (#49) and account/ (#69). rpc_call and rpc_payment_tests drop their prefix and become rpc/call.rs and rpc/payment_tests.rs. Renames only, apart from the #[path] attribute in rpc/call.rs, which now names payment_tests.rs. main.rs re-exports the modules under their old paths, as it does for cli/ and account/, so no imports change. Signed-off-by: James Neve <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third step of the
crates/erpcmodule restructure, aftercli/(#49) andaccount/(#69).Moves the endpoint-facing modules into
crates/erpc/src/rpc/:rpc_call.rsrpc/call.rsrpc_payment_tests.rsrpc/payment_tests.rswebhook.rsrpc/webhook.rswebhook_delivery.rsrpc/webhook_delivery.rsRenames only, with one changed line.
rpc/call.rsloads its tests with#[path], so the attribute now namespayment_tests.rs. The other files move byte-for-byte. The newrpc/mod.rsdeclares the modules, andmain.rsre-exports them under their old paths (rpc::call as rpc_call,webhook,webhook_delivery), as it does forcli/andaccount/. As a result no imports change in this PR.None of the other moved files use
#[path],include_str!or hardcoded test names, and no docs or scripts refer to their paths.Verification
cargo fmt --checkandcargo clippy --workspace --all-targets -- -D warningsare clean.cargo test --workspace: 2,280 passed, 0 failed.erpctest list againstmain: 954 tests on both sides, with the same names apart from the newrpc::paths.--helppages are byte-identical tomain.check-oss-hygiene.shandcheck-endpoints.shpass.