Repository navigation
Stop the dropped-connection test racing the kernel - #5
Merged
Merged
Conversation
The test wrote 16 MB and expected the peer's RST to interrupt the write, but where socket buffers absorb the payload the write finishes and the test fails: it failed CI on main and one local run in three. A small receive buffer, set before bind, keeps the payload from draining. Version moves to 1.0.0-alpha05: alpha04 was uploaded from a tag cut before the code-page fix and cannot be reused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkPrinterTest.reportsFailureWhenThePrinterDropsTheConnectionwrote 16 MB to a socket whose peer closes withSO_LINGER 0, expecting the RST to interrupt the write. Where the kernel's socket buffers absorb the whole payload the write finishes instead and the test fails — it failed CI on main and one local run in three. The server socket now takes a small receive buffer before bind, so the payload cannot drain and the RST always lands mid-write. The test ran green four times in a row afterwards.The version moves to
1.0.0-alpha05:alpha04was uploaded to the Central Portal from a tag cut before the code-page fix, so those coordinates cannot be reused.Verification:
spotlessCheck,:spooler:desktopTest75/75, and the Android, JS and wasm compiles.