Skip to content

extra_applications(:host): guard wx_app_on_disk?/0 against nil #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dominicletz merged 1 commit into from
Aug 8, 2026
Merged

extra_applications(:host): guard wx_app_on_disk?/0 against nil #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@ defmodule Desktop.MixProject do
# is evaluated under `mix deps.compile` — the previous deps' `compile.all`
# prunes the code path and forgets the apps it never listed. Check the
# filesystem directly instead, mirroring what `desktop_wx_stub.exs`
# already does via `wx_headers_resolvable?/0`.
# already does via `wx_headers_resolvable?/0`. The `with` clause guards
# `wx_dir` against `nil` because `Enum.find/2` returns `nil` when no
# `wx-*` directory exists under the OTP root (the case on `--without-wx`
# builds), and an unbound pattern would otherwise let the body run with
# `wx_dir = nil` and crash `Path.join/1`.
if wx_app_on_disk?() do
[:wx]
else
Expand All @@ -106,7 +110,8 @@ defmodule Desktop.MixProject do
root = List.to_string(:code.root_dir())

with {:ok, entries} <- File.ls(Path.join(root, "lib")),
wx_dir <- Enum.find(entries, &String.starts_with?(&1, "wx-")) do
wx_dir when is_binary(wx_dir) <-
Enum.find(entries, &String.starts_with?(&1, "wx-")) do
File.exists?(Path.join([root, "lib", wx_dir, "include", "wx.hrl"]))
else
_ -> false
Expand Down
Loading