Skip to content

SearchListItem: use Granite.ListItem and HeaderLabel - #2448

Merged
danirabbit merged 3 commits into
mainfrom
danirabbit/searchlistitem-granitebox-headerlabel
Oct 9, 2026
Merged

danirabbit merged 3 commits into
mainfrom
danirabbit/searchlistitem-granitebox-headerlabel

Conversation

@danirabbit

@danirabbit danirabbit commented Oct 1, 2026 •

Copy link
Copy Markdown
Member
  • Granite.HeaderLabel handles laying out secondary text for us here and we get a11y free. The only thing we lose is multiple lines of description text
  • Use Granite.ListItem here as well for free padding and Granite.Box for spacing
  • Instead of relying on max-width-chars we can use Adw.ClampScrollable

BEFORE

Screenshot from 2026-10-01 14 59 50

AFTER

Screenshot from 2026-10-01 15 10 01

@danirabbit
danirabbit requested a review from a team October 1, 2026 22:12
@danirabbit danirabbit added this to OS 9 Oct 1, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Oct 1, 2026
@danirabbit
danirabbit requested a review from a team October 9, 2026 15:20
@danirabbit
danirabbit enabled auto-merge (squash) October 9, 2026 15:20
@danirabbit
danirabbit merged commit 03bf439 into main Oct 9, 2026
4 checks passed
@danirabbit
danirabbit deleted the danirabbit/searchlistitem-granitebox-headerlabel branch October 9, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants